Avoid duplicated "New" wording for direct editing creator labels - #17355
Avoid duplicated "New" wording for direct editing creator labels#17355ChristianTannheimer wants to merge 4 commits into
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…34.1.0-rc1 chore: version bump 34.1.0 RC1
Signed-off-by: Christian Tannheimer <chtannheimer@gmail.com>
Signed-off-by: ChristianTannheimer <94762133+ChristianTannheimer@users.noreply.github.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
Fixes #17354
Problem
ONLYOFFICE-based connectors provide full phrases as Direct Editing creator
names ("Neues Dokument" / "New document"). Prefixing the localized "New"
produces duplicated wording like "Neu Neues Dokument" / "New New document".
Solution
Only apply the prefix when the creator name does not already start with the
localized "New" (case-insensitive); otherwise use the server-provided name
as-is. Entries like "Neu Textdokument" / "Neu Whiteboard" are unaffected.
Note: this is a heuristic — for locales where the inflected "new" doesn't
share the prefix string, behavior simply falls back to the current one, so
there is no regression.
Testing
Built
versionDevDebugfromrc-34.1.0-01+ this change, tested on aSamsung Galaxy S25+ against Nextcloud 34.0.1 with the EuroOffice connector
11.0.1 and the official ONLYOFFICE connector 10.1.2.
before
after
